Re: [PATCH] use vmalloc for mem_cgroup allocation. v2

[Li Zefan]

KAMEZAWA Hiroyuki wrote:
> On Mon, 14 Apr 2008 19:17:30 -0700
> Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>> Well...  vmalloced memory is of course a little slower to use - additional
>> TLB pressure.
>>
>> Do you think the memcgroup is accessed frequently enough to use vmalloc()
>> only on those architectures which actually need it?
>>
>> Because it'd be pretty simple to implement:
>>
>> 	if (sizeof(struct mem_group) > PAGE_SIZE)
>> 		vmalloc()
>> 	else
>> 		kmalloc()
>>
>> 	...
>>
>> 	if (sizeof(struct mem_group) > PAGE_SIZE)
>> 		vfree()
>> 	else
>> 		kfree()
>>
>> the compiler will optimise away the `if'.
>>
> 
> Hmm, ok. I'll rewrite one to do that.
> 

It will be better to use wrappers for these: mem_cgroup_alloc() and mem_cgroup_free()

> Thanks,
> -Kame
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/