Re: [PATCH] proc: convert /proc/tty/ldiscs to seq_file interface

From: Andrew Morton
Date: Tue Apr 15 2008 - 02:39:21 EST


On Sun, 13 Apr 2008 00:59:23 +0400 Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:

> @@ -224,7 +239,6 @@ void __init proc_tty_init(void)
> * entry.
> */
> proc_tty_driver = proc_mkdir_mode("tty/driver", S_IRUSR | S_IXUSR, NULL);
> -
> - create_proc_read_entry("tty/ldiscs", 0, NULL, tty_ldiscs_read_proc, NULL);
> + proc_create("tty/ldiscs", 0, NULL, &tty_ldiscs_proc_fops);
> proc_create("tty/drivers", 0, NULL, &proc_tty_drivers_operations);
> }

hm. proc_tty_init() used to check for _some_ procfs API failures. Now it
doesn't do any checking at all.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/