Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue

[Andi Kleen]

David Miller <davem@xxxxxxxxxxxxx> writes:

> From: Andi Kleen <andi@xxxxxxxxxxxxxx>
> Date: Tue, 15 Apr 2008 09:59:40 +0200
>
>> Vitaliy Gusev <vgusev@xxxxxxxxxx> writes:
>> 
>> > Hello!
>> >
>> > tcp_prune_queue() doesn't prune an out-of-order queue at all.
>> 
>> Why are you saying this? It has code to prune the ooo queue. You're even
>> moving it in your patch.
>> 
>> You're saying that the code doesn't work? If yes why? 
>
> There are inappropriate guards there, and it didn't get invoked
> from another important code path.
>
> That's what his change is fixing.

Perhaps I'm dense, but I don't see the inappropiate guards. The 
guards are pretty much the same as before.

The main difference seems to be that
sk_rmem_schedule/__sk_mem_schedule is called more often, but it is 
unclear how this affects the ooo pruning which only checks
the queue length anyways.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/