Re: [PATCH 1/5] Clocklib: add generic framework for managingclocks.

[Dmitry Baryshkov]

On Mon, Apr 14, 2008 at 11:13:30PM -0700, Andrew Morton wrote:
> On Sun, 13 Apr 2008 18:43:12 +0400 Dmitry Baryshkov <dbaryshkov@xxxxxxxxx> wrote:
> 
> > +#define FUNC_TO_CLK(func)	&(&(struct clk_function) func)->clk
> 
> scratched my head for a while, was unable to work out what this does.
> It is unused, so I think it can be zapped?

It take clk_function and returns pointer to the contained struct clk.
It's unused in the submitted code, but it's used in the yet-in-progress
drivers for Toshiba companion chips. I used it to be able to write
things like:

static struct clk *clks[] = {
        [TC6387XB_CLK_MMC] = FUNC_TO_CLK(MFD_CLK_FUNC(NULL, "MMCCLK",
				&tc6387xb_cells[TC6387XB_CELL_MMC])),
};

where MFD_CLK_FUNC instantiates some special sort of clk_function.

> 
> All the inlined functions in clklib.h are waaaaaaaaaaaay too big
> to be inlined.  Did I fail to notice that last time around?

OK.

> 
> Anyway, this patchset is basically an arm-only thing, so I'll need
> guidance, please...

They were posted to the LKML with CC to arch maintainers primary to get
their feedback. I have a hope that it can be used not only for various
arms, but for other arches. As you can see posting it here helped to make
the whole patchset better and less memory hungry.

As currently the patchset only contains the generic and ARM-related
things, I think it can and should go in via Russell, if he agrees.

Russell?

-- 
With best wishes
Dmitry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/