Re: + s390-tty-prepare-for-put_char-to-return-success-fail.patchadded to -mm tree

From: Heiko Carstens
Date: Tue Apr 15 2008 - 06:45:38 EST


On Tue, Apr 15, 2008 at 11:11:01AM +0100, Alan Cox wrote:
> > is allowed or not (1 means yes). Somebody told me that the put_char routine
> > will only be called from schedulable context, which now doesn't seem to be
> > true?!
>
> It isnt true.
>
> > For the console functions we pass indeed 0 to __sclp_vt220_write since printk
> > may be called within any context. Is that also true for the tty put_char
> > routine?
>
> Yes, but failing a put_char is perfectly acceptable.

Ok, thanks for pointing this out! We are going to fix this as soon as your
patch is merged, so we can avoid further merge conflicts.
I assume your patch is for 2.6.26?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/