Re: gart: factor out common code

[SL Baur]

On 4/15/08, Pavel Machek <pavel@xxxxxx> wrote:
> Cleanup gart handling on amd64 a bit: move common code into
>  enable_gart_translation , and use symbolic register names where
>  appropriate.
>
>  Signed-off-by: Pavel Machek <pavel@xxxxxxx>

Which source tree is this patch against?  I'm looking at Linus
latest and I don't see the AMD64_* constants defined in the
same place.

Other reviewer comments:
The casting between struct pci_dev * and u64 is kind of ugly,
I presume the reason for the narrowing casts in the block of
code you moved is documented somewhere.

It looks OK as far as I can see, but I'm not looking at the same
source code, so I don't think I should add a Reviewed-by:.

-sb
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/