Re: Fw: [2.6 patch] make cifs_dfs_automount_list static

[Al Viro]

On Tue, Apr 15, 2008 at 10:58:06PM -0500, Steve French wrote:
> Merged into cifs-2.6.git tree
> 
> > Adrian Bunk <bunk@xxxxxxxxxx>
> > 04/14/2008 01:13 PM
> >
> > To
> > Igor Mammedov <niallain@xxxxxxxxx>, Steven French/Austin/IBM@IBMUS
> > cc
> > linux-cifs-client@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
> > Subject
> > [2.6 patch] make cifs_dfs_automount_list static
> >
> >
> > This patch makes the needlessly global cifs_dfs_automount_list static.

This only hides the real problem, namely that logics in the user of said
list is FUBAR.

What kind of eviction policy does cifs want?  "Try to kick all such
mounts out whenever somebody does umount(2) on any mounted cifs instance"?
That's bloody odd, to put it mildly...  "Don't kick them out until
somebody tries to umount cifs instance they are mounted on"?  That's
done automatically from VFS these days (and should've been done that
way as soon as that kind of automounts had been introduced).  "Done
frequently enough"?  Then you want timer, like e.g. NFS does...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/