RE: [patch] cciss: fix warning oops on rmmod of driver

[Miller, Mike (OS Dev)]

> -----Original Message-----
> From: scameron@xxxxxxxxxxxxxxxxxxxxxxx
> [mailto:scameron@xxxxxxxxxxxxxxxxxxxxxxx]
> Sent: Wednesday, April 16, 2008 2:01 PM
> To: Jens Axboe
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Miller, Mike (OS Dev);
> mikem@xxxxxxxxxxxxxxxxxxxxxxx
> Subject: [patch] cciss: fix warning oops on rmmod of driver
>
>
> * Fix oops on cciss rmmod due to calling pci_free_consistent with
>   irqs disabled.
>
> Signed-off-by: Stephen M. Cameron <scameron@xxxxxxxxxxxxxxxxxxxxxxx>

Acked-by: Mike Miller <mike.miller@xxxxxx>

> ---
>
>  linux-2.6.25-rc9/drivers/block/cciss_scsi.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN
> linux-2.6.25-rc9/drivers/block/cciss_scsi.c~pci_free_consisten
> t_oops linux-2.6.25-rc9/drivers/block/cciss_scsi.c
> ---
> root/linux-2.6.25-rc9/drivers/block/cciss_scsi.c~pci_free_cons
> istent_oops   2008-04-16 12:58:53.000000000 -0500
> +++ root-root/linux-2.6.25-rc9/drivers/block/cciss_scsi.c
>   2008-04-16 12:59:22.000000000 -0500
> @@ -1349,9 +1349,9 @@ cciss_unregister_scsi(int ctlr)
>         /* set scsi_host to NULL so our detect routine will
>            find us on register */
>         sa->scsi_host = NULL;
> +       spin_unlock_irqrestore(CCISS_LOCK(ctlr), flags);
>         scsi_cmd_stack_free(ctlr);
>         kfree(sa);
> -       spin_unlock_irqrestore(CCISS_LOCK(ctlr), flags);
>  }
>
>  static int
> _
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/