Re: [alsa-devel] [PATCH] SOC: fix tests in cs4270_hw_params()

[Takashi Iwai]

At Thu, 17 Apr 2008 17:45:39 +0200,
Roel Kluin wrote:
> 
> cs4270_hw_params does several times:
> 
> ret = snd_soc_write()
> if (ret < 0)
> 	...
> 
> This only works when ret is signed.
> 
> Signed-off-by: Roel Kluin <12o3l@xxxxxxxxxx>

Applied to ALSA tree.  Thanks.


Takashi

> ---
> diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c
> index bf2ab72..e73fcfd 100644
> --- a/sound/soc/codecs/cs4270.c
> +++ b/sound/soc/codecs/cs4270.c
> @@ -372,7 +372,7 @@ static int cs4270_hw_params(struct snd_pcm_substream *substream,
>  	struct snd_soc_device *socdev = rtd->socdev;
>  	struct snd_soc_codec *codec = socdev->codec;
>  	struct cs4270_private *cs4270 = codec->private_data;
> -	unsigned int ret = 0;
> +	int ret;
>  	unsigned int i;
>  	unsigned int rate;
>  	unsigned int ratio;
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@xxxxxxxxxxxxxxxx
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/