[patch 35/53] PNP: remove pnp_resource_table references from resource decoders
From: Bjorn Helgaas
Date: Fri Apr 18 2008 - 17:05:53 EST
This removes a few more references to the pnp_resource_table.
No functional change.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
---
drivers/pnp/isapnp/core.c | 87 ++++++++++++++++++++--------------------
drivers/pnp/pnpacpi/rsparser.c | 88 ++++++++++++++++++++++-------------------
drivers/pnp/pnpbios/rsparser.c | 82 +++++++++++++++++++++-----------------
3 files changed, 138 insertions(+), 119 deletions(-)
Index: work8/drivers/pnp/isapnp/core.c
===================================================================
--- work8.orig/drivers/pnp/isapnp/core.c 2008-04-17 15:00:51.000000000 -0600
+++ work8/drivers/pnp/isapnp/core.c 2008-04-17 15:02:30.000000000 -0600
@@ -923,7 +923,7 @@
static int isapnp_read_resources(struct pnp_dev *dev)
{
- struct pnp_resource_table *res = dev->res;
+ struct resource *res;
int tmp, ret;
dev->active = isapnp_read_byte(ISAPNP_CFG_ACTIVATE);
@@ -932,16 +932,18 @@
ret = isapnp_read_word(ISAPNP_CFG_PORT + (tmp << 1));
if (!ret)
continue;
- res->port_resource[tmp].start = ret;
- res->port_resource[tmp].flags = IORESOURCE_IO;
+ res = &dev->res->port_resource[tmp];
+ res->start = ret;
+ res->flags = IORESOURCE_IO;
}
for (tmp = 0; tmp < ISAPNP_MAX_MEM; tmp++) {
ret =
isapnp_read_word(ISAPNP_CFG_MEM + (tmp << 3)) << 8;
if (!ret)
continue;
- res->mem_resource[tmp].start = ret;
- res->mem_resource[tmp].flags = IORESOURCE_MEM;
+ res = &dev->res->mem_resource[tmp];
+ res->start = ret;
+ res->flags = IORESOURCE_MEM;
}
for (tmp = 0; tmp < ISAPNP_MAX_IRQ; tmp++) {
ret =
@@ -949,17 +951,17 @@
8);
if (!ret)
continue;
- res->irq_resource[tmp].start =
- res->irq_resource[tmp].end = ret;
- res->irq_resource[tmp].flags = IORESOURCE_IRQ;
+ res = &dev->res->irq_resource[tmp];
+ res->start = res->end = ret;
+ res->flags = IORESOURCE_IRQ;
}
for (tmp = 0; tmp < ISAPNP_MAX_DMA; tmp++) {
ret = isapnp_read_byte(ISAPNP_CFG_DMA + tmp);
if (ret == 4)
continue;
- res->dma_resource[tmp].start =
- res->dma_resource[tmp].end = ret;
- res->dma_resource[tmp].flags = IORESOURCE_DMA;
+ res = &dev->res->dma_resource[tmp];
+ res->start = res->end = ret;
+ res->flags = IORESOURCE_DMA;
}
}
return 0;
@@ -978,42 +980,41 @@
static int isapnp_set_resources(struct pnp_dev *dev)
{
- struct pnp_resource_table *res = dev->res;
+ struct resource *res;
int tmp;
isapnp_cfg_begin(dev->card->number, dev->number);
dev->active = 1;
- for (tmp = 0;
- tmp < ISAPNP_MAX_PORT
- && (res->port_resource[tmp].
- flags & (IORESOURCE_IO | IORESOURCE_UNSET)) == IORESOURCE_IO;
- tmp++)
- isapnp_write_word(ISAPNP_CFG_PORT + (tmp << 1),
- res->port_resource[tmp].start);
- for (tmp = 0;
- tmp < ISAPNP_MAX_IRQ
- && (res->irq_resource[tmp].
- flags & (IORESOURCE_IRQ | IORESOURCE_UNSET)) == IORESOURCE_IRQ;
- tmp++) {
- int irq = res->irq_resource[tmp].start;
- if (irq == 2)
- irq = 9;
- isapnp_write_byte(ISAPNP_CFG_IRQ + (tmp << 1), irq);
- }
- for (tmp = 0;
- tmp < ISAPNP_MAX_DMA
- && (res->dma_resource[tmp].
- flags & (IORESOURCE_DMA | IORESOURCE_UNSET)) == IORESOURCE_DMA;
- tmp++)
- isapnp_write_byte(ISAPNP_CFG_DMA + tmp,
- res->dma_resource[tmp].start);
- for (tmp = 0;
- tmp < ISAPNP_MAX_MEM
- && (res->mem_resource[tmp].
- flags & (IORESOURCE_MEM | IORESOURCE_UNSET)) == IORESOURCE_MEM;
- tmp++)
- isapnp_write_word(ISAPNP_CFG_MEM + (tmp << 3),
- (res->mem_resource[tmp].start >> 8) & 0xffff);
+ for (tmp = 0; tmp < ISAPNP_MAX_PORT; tmp++) {
+ res = &dev->res->port_resource[tmp];
+ if ((res->flags & (IORESOURCE_IO | IORESOURCE_UNSET)) ==
+ IORESOURCE_IO)
+ isapnp_write_word(ISAPNP_CFG_PORT + (tmp << 1),
+ res->start);
+ }
+ for (tmp = 0; tmp < ISAPNP_MAX_IRQ; tmp++) {
+ res = &dev->res->irq_resource[tmp];
+ if ((res->flags & (IORESOURCE_IRQ | IORESOURCE_UNSET)) ==
+ IORESOURCE_IRQ) {
+ int irq = res->start;
+ if (irq == 2)
+ irq = 9;
+ isapnp_write_byte(ISAPNP_CFG_IRQ + (tmp << 1), irq);
+ }
+ }
+ for (tmp = 0; tmp < ISAPNP_MAX_DMA; tmp++) {
+ res = &dev->res->dma_resource[tmp];
+ if ((res->flags & (IORESOURCE_DMA | IORESOURCE_UNSET)) ==
+ IORESOURCE_DMA)
+ isapnp_write_byte(ISAPNP_CFG_DMA + tmp, res->start);
+ }
+ for (tmp = 0; tmp < ISAPNP_MAX_MEM; tmp++) {
+ res = &dev->res->mem_resource[tmp];
+ if ((res->flags & (IORESOURCE_MEM | IORESOURCE_UNSET)) ==
+ IORESOURCE_MEM)
+ isapnp_write_word(ISAPNP_CFG_MEM + (tmp << 3),
+ (res->start >> 8) & 0xffff);
+ }
/* FIXME: We aren't handling 32bit mems properly here */
isapnp_activate(dev->number);
isapnp_cfg_end();
Index: work8/drivers/pnp/pnpacpi/rsparser.c
===================================================================
--- work8.orig/drivers/pnp/pnpacpi/rsparser.c 2008-04-17 15:00:51.000000000 -0600
+++ work8/drivers/pnp/pnpacpi/rsparser.c 2008-04-17 15:02:30.000000000 -0600
@@ -82,8 +82,8 @@
u32 gsi, int triggering,
int polarity, int shareable)
{
- struct pnp_resource_table *res = dev->res;
- int i = 0;
+ struct resource *res;
+ int i;
int irq;
int p, t;
static unsigned char warned;
@@ -91,9 +91,11 @@
if (!valid_IRQ(gsi))
return;
- while (!(res->irq_resource[i].flags & IORESOURCE_UNSET) &&
- i < PNP_MAX_IRQ)
- i++;
+ for (i = 0; i < PNP_MAX_IRQ; i++) {
+ res = &dev->res->irq_resource[i];
+ if (res->flags & IORESOURCE_UNSET)
+ break;
+ }
if (i >= PNP_MAX_IRQ && !warned) {
printk(KERN_WARNING "pnpacpi: exceeded the max number of IRQ "
"resources: %d \n", PNP_MAX_IRQ);
@@ -117,16 +119,16 @@
}
}
- res->irq_resource[i].flags = IORESOURCE_IRQ; // Also clears _UNSET flag
- res->irq_resource[i].flags |= irq_flags(triggering, polarity, shareable);
+ res->flags = IORESOURCE_IRQ; // Also clears _UNSET flag
+ res->flags |= irq_flags(triggering, polarity, shareable);
irq = acpi_register_gsi(gsi, triggering, polarity);
if (irq < 0) {
- res->irq_resource[i].flags |= IORESOURCE_DISABLED;
+ res->flags |= IORESOURCE_DISABLED;
return;
}
- res->irq_resource[i].start = irq;
- res->irq_resource[i].end = irq;
+ res->start = irq;
+ res->end = irq;
pcibios_penalize_isa_irq(irq, 1);
}
@@ -176,22 +178,24 @@
static void pnpacpi_parse_allocated_dmaresource(struct pnp_dev *dev,
u32 dma, int flags)
{
- struct pnp_resource_table *res = dev->res;
- int i = 0;
+ struct resource *res;
+ int i;
static unsigned char warned;
- while (i < PNP_MAX_DMA &&
- !(res->dma_resource[i].flags & IORESOURCE_UNSET))
- i++;
+ for (i = 0; i < PNP_MAX_DMA; i++) {
+ res = &dev->res->dma_resource[i];
+ if (res->flags & IORESOURCE_UNSET)
+ break;
+ }
if (i < PNP_MAX_DMA) {
- res->dma_resource[i].flags = IORESOURCE_DMA; // Also clears _UNSET flag
- res->dma_resource[i].flags |= flags;
+ res->flags = IORESOURCE_DMA; // Also clears _UNSET flag
+ res->flags |= flags;
if (dma == -1) {
- res->dma_resource[i].flags |= IORESOURCE_DISABLED;
+ res->flags |= IORESOURCE_DISABLED;
return;
}
- res->dma_resource[i].start = dma;
- res->dma_resource[i].end = dma;
+ res->start = dma;
+ res->end = dma;
} else if (!warned) {
printk(KERN_WARNING "pnpacpi: exceeded the max number of DMA "
"resources: %d \n", PNP_MAX_DMA);
@@ -202,23 +206,25 @@
static void pnpacpi_parse_allocated_ioresource(struct pnp_dev *dev,
u64 io, u64 len, int io_decode)
{
- struct pnp_resource_table *res = dev->res;
- int i = 0;
+ struct resource *res;
+ int i;
static unsigned char warned;
- while (!(res->port_resource[i].flags & IORESOURCE_UNSET) &&
- i < PNP_MAX_PORT)
- i++;
+ for (i = 0; i < PNP_MAX_PORT; i++) {
+ res = &dev->res->port_resource[i];
+ if (res->flags & IORESOURCE_UNSET)
+ break;
+ }
if (i < PNP_MAX_PORT) {
- res->port_resource[i].flags = IORESOURCE_IO; // Also clears _UNSET flag
+ res->flags = IORESOURCE_IO; // Also clears _UNSET flag
if (io_decode == ACPI_DECODE_16)
- res->port_resource[i].flags |= PNP_PORT_FLAG_16BITADDR;
+ res->flags |= PNP_PORT_FLAG_16BITADDR;
if (len <= 0 || (io + len - 1) >= 0x10003) {
- res->port_resource[i].flags |= IORESOURCE_DISABLED;
+ res->flags |= IORESOURCE_DISABLED;
return;
}
- res->port_resource[i].start = io;
- res->port_resource[i].end = io + len - 1;
+ res->start = io;
+ res->end = io + len - 1;
} else if (!warned) {
printk(KERN_WARNING "pnpacpi: exceeded the max number of IO "
"resources: %d \n", PNP_MAX_PORT);
@@ -230,24 +236,26 @@
u64 mem, u64 len,
int write_protect)
{
- struct pnp_resource_table *res = dev->res;
- int i = 0;
+ struct resource *res;
+ int i;
static unsigned char warned;
- while (!(res->mem_resource[i].flags & IORESOURCE_UNSET) &&
- (i < PNP_MAX_MEM))
- i++;
+ for (i = 0; i < PNP_MAX_MEM; i++) {
+ res = &dev->res->mem_resource[i];
+ if (res->flags & IORESOURCE_UNSET)
+ break;
+ }
if (i < PNP_MAX_MEM) {
- res->mem_resource[i].flags = IORESOURCE_MEM; // Also clears _UNSET flag
+ res->flags = IORESOURCE_MEM; // Also clears _UNSET flag
if (len <= 0) {
- res->mem_resource[i].flags |= IORESOURCE_DISABLED;
+ res->flags |= IORESOURCE_DISABLED;
return;
}
if (write_protect == ACPI_READ_WRITE_MEMORY)
- res->mem_resource[i].flags |= IORESOURCE_MEM_WRITEABLE;
+ res->flags |= IORESOURCE_MEM_WRITEABLE;
- res->mem_resource[i].start = mem;
- res->mem_resource[i].end = mem + len - 1;
+ res->start = mem;
+ res->end = mem + len - 1;
} else if (!warned) {
printk(KERN_WARNING "pnpacpi: exceeded the max number of mem "
"resources: %d\n", PNP_MAX_MEM);
Index: work8/drivers/pnp/pnpbios/rsparser.c
===================================================================
--- work8.orig/drivers/pnp/pnpbios/rsparser.c 2008-04-17 15:00:51.000000000 -0600
+++ work8/drivers/pnp/pnpbios/rsparser.c 2008-04-17 15:02:30.000000000 -0600
@@ -56,80 +56,90 @@
static void pnpbios_parse_allocated_irqresource(struct pnp_dev *dev, int irq)
{
- struct pnp_resource_table *res = dev->res;
- int i = 0;
+ struct resource *res;
+ int i;
+
+ for (i = 0; i < PNP_MAX_IRQ; i++) {
+ res = &dev->res->irq_resource[i];
+ if (res->flags & IORESOURCE_UNSET)
+ break;
+ }
- while (!(res->irq_resource[i].flags & IORESOURCE_UNSET)
- && i < PNP_MAX_IRQ)
- i++;
if (i < PNP_MAX_IRQ) {
- res->irq_resource[i].flags = IORESOURCE_IRQ; // Also clears _UNSET flag
+ res->flags = IORESOURCE_IRQ; // Also clears _UNSET flag
if (irq == -1) {
- res->irq_resource[i].flags |= IORESOURCE_DISABLED;
+ res->flags |= IORESOURCE_DISABLED;
return;
}
- res->irq_resource[i].start =
- res->irq_resource[i].end = (unsigned long)irq;
+ res->start = res->end = (unsigned long)irq;
pcibios_penalize_isa_irq(irq, 1);
}
}
static void pnpbios_parse_allocated_dmaresource(struct pnp_dev *dev, int dma)
{
- struct pnp_resource_table *res = dev->res;
- int i = 0;
+ struct resource *res;
+ int i;
+
+ for (i = 0; i < PNP_MAX_DMA; i++) {
+ res = &dev->res->dma_resource[i];
+ if (res->flags & IORESOURCE_UNSET)
+ break;
+ }
- while (i < PNP_MAX_DMA &&
- !(res->dma_resource[i].flags & IORESOURCE_UNSET))
- i++;
if (i < PNP_MAX_DMA) {
- res->dma_resource[i].flags = IORESOURCE_DMA; // Also clears _UNSET flag
+ res->flags = IORESOURCE_DMA; // Also clears _UNSET flag
if (dma == -1) {
- res->dma_resource[i].flags |= IORESOURCE_DISABLED;
+ res->flags |= IORESOURCE_DISABLED;
return;
}
- res->dma_resource[i].start =
- res->dma_resource[i].end = (unsigned long)dma;
+ res->start = res->end = (unsigned long)dma;
}
}
static void pnpbios_parse_allocated_ioresource(struct pnp_dev *dev,
int io, int len)
{
- struct pnp_resource_table *res = dev->res;
- int i = 0;
+ struct resource *res;
+ int i;
+
+ for (i = 0; i < PNP_MAX_PORT; i++) {
+ res = &dev->res->port_resource[i];
+ if (res->flags & IORESOURCE_UNSET)
+ break;
+ }
- while (!(res->port_resource[i].flags & IORESOURCE_UNSET)
- && i < PNP_MAX_PORT)
- i++;
if (i < PNP_MAX_PORT) {
- res->port_resource[i].flags = IORESOURCE_IO; // Also clears _UNSET flag
+ res->flags = IORESOURCE_IO; // Also clears _UNSET flag
if (len <= 0 || (io + len - 1) >= 0x10003) {
- res->port_resource[i].flags |= IORESOURCE_DISABLED;
+ res->flags |= IORESOURCE_DISABLED;
return;
}
- res->port_resource[i].start = (unsigned long)io;
- res->port_resource[i].end = (unsigned long)(io + len - 1);
+ res->start = (unsigned long)io;
+ res->end = (unsigned long)(io + len - 1);
}
}
static void pnpbios_parse_allocated_memresource(struct pnp_dev *dev,
int mem, int len)
{
- struct pnp_resource_table *res = dev->res;
- int i = 0;
+ struct resource *res;
+ int i;
+
+ for (i = 0; i < PNP_MAX_MEM; i++) {
+ res = &dev->res->mem_resource[i];
+ if (res->flags & IORESOURCE_UNSET)
+ break;
+ }
- while (!(res->mem_resource[i].flags & IORESOURCE_UNSET)
- && i < PNP_MAX_MEM)
- i++;
if (i < PNP_MAX_MEM) {
- res->mem_resource[i].flags = IORESOURCE_MEM; // Also clears _UNSET flag
+ res->flags = IORESOURCE_MEM; // Also clears _UNSET flag
if (len <= 0) {
- res->mem_resource[i].flags |= IORESOURCE_DISABLED;
+ res->flags |= IORESOURCE_DISABLED;
return;
}
- res->mem_resource[i].start = (unsigned long)mem;
- res->mem_resource[i].end = (unsigned long)(mem + len - 1);
+ res->start = (unsigned long)mem;
+ res->end = (unsigned long)(mem + len - 1);
}
}
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/