Re: x86: clean up non-smp usage of cpu maps

From: Andrew Morton
Date: Fri Apr 18 2008 - 21:50:12 EST


On Fri, 18 Apr 2008 17:36:55 GMT Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx> wrote:

> x86: clean up non-smp usage of cpu maps
>
> Cleanup references to the early cpu maps for the non-SMP configuration
> and remove some functions called for SMP configurations only.
>
> ...
>
> index 1179aa0..dc79409 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -10,7 +10,7 @@
> #include <asm/setup.h>
> #include <asm/topology.h>
>
> -#ifdef CONFIG_HAVE_SETUP_PER_CPU_AREA
> +#if defined(CONFIG_HAVE_SETUP_PER_CPU_AREA) && defined(CONFIG_SMP)

This implies that we can have

CONFIG_HAVE_SETUP_PER_CPU_AREA && !CONFIG_SMP

which a) appears to be true and b) seems rather dumb?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/