Re: [bug] build failure in net/netfilter/nf_conntrack_sip.c, onlatest -git

[Jan Engelhardt]

On Saturday 2008-04-19 12:07, David Miller wrote:
>> randconfig testing found a netfilter build failure in latest -git:
>> 
>>   net/netfilter/nf_conntrack_sip.c: In function 'set_expected_rtp_rtcp':
>>   net/netfilter/nf_conntrack_sip.c:786: error: 'struct nf_conntrack_expect' has no member named 'saved_ip'
>> 
>>   http://redhat.com/~mingo/misc/config-Sat_Apr_19_11_37_02_CEST_2008.bad
>> 
>> disabling CONFIG_NF_CONNTRACK_SIP works it around.
>
>I think this will fix it.
>
>Patrick, is this how we should do it?
>
> config NF_CONNTRACK_SIP
> 	tristate "SIP protocol support"
>-	depends on NF_CONNTRACK
>+	depends on NF_CONNTRACK && NF_NAT
> 	default m if NETFILTER_ADVANCED=n

Not really. One may want to run a system without NAT,
but still with connection tracking (for firewalling) -- think IPv6.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/