Re: [GIT PATCH] SCSI updates for 2.6.25

[Linus Torvalds]

On Sat, 19 Apr 2008, James Bottomley wrote:
> 
> Well, we already had this argument on linux-scsi when the interface was
> first proposed:  Apart from select being very nasty and should only be
> sparingly used

I'm still not understanding people who say that.

Yes, select has problems, in that it doesn't guarantee dependencies.

But that said, select is a whole lot better than having simply *different* 
behaviour (or build errors) depending on totally unrelated config options.

So people: stop this total *idiocy* with "select is bad". It's not. The 
lack of select is *much* worse.

If you want LIBSAS to have two different modes, how about just making that 
explicit in the configuration, ie using something like

	config LIBSAS_SET_ADDR
		bool "Provide user-settable SAS address" 
		depends on SCSI_SAS_LIBSAS
		help
		  This allows a runtime "firmware" loader that loads the 
		  SAS address

	config LIBSAS_SET_ADDR_FWLOAD
		tristate
		depends on SCSI_SAS_LIBSAS && LIBSAS_SET_ADDR
		default y
		select FW_LOADER

and now you have the explicit option to turn it on or off - and FW_LOADER 
is loaded appropriately.

> Even if I changed it to select, a user could still defeat it by making
> CONFIG_SCSI_AIC94XX=y (because now the initialisation is before early
> boot userland, so the request always fails).

Not true. That's why we have initrd and ramdisks etc.

Not that any normal people will ever care about LIBSAS, but anyway.. The 
ones that do care about these kinds of things are probably happy to have 
special initrd images.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/