Re: [PATCH 6/8] omfs: add bitmap routines

[Marcin Slusarz]

On Sat, Apr 19, 2008 at 04:37:35PM -0400, Bob Copeland wrote:
> +unsigned long omfs_count_free(struct super_block *sb)
> +{
> +	unsigned int i, j;
> +	u64 *map;
> +	unsigned long sum = 0;
> +	struct omfs_sb_info *sbi = OMFS_SB(sb);
> +
> +	for (i = 0; i < sbi->s_imap_size; i++) {
> +		map = (u64 *) sbi->s_imap[i];
> +		for (j = 0; j < sb->s_blocksize / 8; j++)
> +			sum += hweight64(~map[j]);
> +	}
> +	return sum;
> +}
I think inner loop can be replaced with something like:
sum += sb->s_blocksize * 8 - bitmap_weight(map, sb->s_blocksize * 8);

Marcin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/