Re: [PATCH] Stringify support commas

[Mathieu Desnoyers]

* Sam Ravnborg (sam@xxxxxxxxxxxx) wrote:
> On Sun, Apr 20, 2008 at 02:32:56PM -0400, Mathieu Desnoyers wrote:
> > #define MYDEF a, b, c
> > 
> > __stringify(MYDEF) should be replaced by "a, b, c", but compilation fails
> > because the __stringify macro expects only one argument. Fix it by using
> > variable macro arguments in __stringify and __stringify_1.
> > 
> > Needed in my current NMI safe iret paravirt support work so I can expand
> > a macro containing assembly code into a string.
> 
> This is a no-no for those archs that still use -traditional.
> I dunno if this is a problem for you at the moment and the
> right fix is anyway to nuke -traditional.
> 
> 	Sam

A quick grep through arch/ gives me the following :

arch/cris/arch-v10/boot/compressed/Makefile
        @$(CC) -D__ASSEMBLY__ -traditional -c $< -o $@
arch/cris/arch-v10/boot/rescue/Makefile
asflags-y += -traditional
arch/cris/arch-v10/lib/Makefile
EXTRA_AFLAGS := -traditional
arch/h8300/boot/compressed/Makefile
EXTRA_AFLAGS    := -traditional
arch/m32r/boot/compressed/Makefile
EXTRA_AFLAGS    := -traditional
arch/m32r/kernel/Makefile
EXTRA_AFLAGS    := -traditional
arch/m68k/fpsp040/Makefile
EXTRA_AFLAGS := -traditional
arch/m68k/ifpsp060/Makefile
EXTRA_AFLAGS := -traditional
arch/m68k/kernel/Makefile
EXTRA_AFLAGS := -traditional
arch/m68k/lib/Makefile
EXTRA_AFLAGS := -traditional
arch/m68k/math-emu/Makefile
EXTRA_AFLAGS := -traditional
arch/parisc/kernel/Makefile
AFLAGS_entry.o  := -traditional
AFLAGS_pacache.o := -traditional
arch/powerpc/boot/Makefile
BOOTAFLAGS      := -D__ASSEMBLY__ $(BOOTCFLAGS) -traditional -nostdinc
arch/s390/kernel/Makefile
EXTRA_AFLAGS    := -traditional
arch/s390/lib/Makefile
EXTRA_AFLAGS := -traditional
arch/s390/math-emu/Makefile
EXTRA_AFLAGS := -traditional
arch/sh/boot/compressed/Makefile_32
EXTRA_AFLAGS    := -traditional
arch/sh/boot/compressed/Makefile_64
EXTRA_AFLAGS    := -traditional

Would their removal break something ?

Mathieu

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/