Re: migration thread and active_load_balance

From: Dan Upton
Date: Mon Apr 21 2008 - 15:39:00 EST


On Mon, Apr 21, 2008 at 7:03 AM, Dmitry Adamushko
<dmitry.adamushko@xxxxxxxxx> wrote:
> On 21/04/2008, Dan Upton <upton.dan.linux@xxxxxxxxx> wrote:
> > [ ... ]
>
> >
> > kernel BUG at kernel/sched.c:2103
>
> and what's this line in your patched sched.c?
>
> is it -- BUG_ON(!irqs_disabled()); ?
>
> anything in your unposted code (e.g. find_coolest_cpu()) that might
> re-enable the interrupts before __migration_task() is called?
>
> If you post your modifications as a patch
> (Documentation/applying-patches.txt) that contains _all_ relevant
> modifications, it'd be easier to guess what's wrong.

Yes, that's the line. I don't recall ever reenabling interrupts, but
maybe somebody will see what I'm missing. I've attached a full diff;
there are a few other places I've made changes for other scheduling
stuff that you'll see in the diff, that have all tested fine.

-dan

Attachment: thermdiff
Description: Binary data