Re: StackProtector Oopses - Re: 2.6.25-mm1

[Valdis . Kletnieks]

On Mon, 21 Apr 2008 18:48:59 PDT, Arjan van de Ven said:

Typo alert?

> diff --git a/kernel/panic.c b/kernel/panic.c
> index c92c1e2..b4a6a05 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -351,7 +351,10 @@ static noinline void __stack_chk_test_func(void)
>  	}
>  #endif
>  	barrier();
> -	memset(&foo, 0, 2*sizeof(foo)); /* deliberate buffer overflow */
> +	if (current->stack_canary == *(((unsigned long *)&foo)+1))
> +		*(((unsigned long *)&foo)+1) = 0;
> +	else
> +		printk(KERN_ERR "No -ftack-protector canary found\n");
                                     -fstack?
>  	barrier();
>  }

Attachment: pgp00000.pgp
Description: PGP signature