Re: 2.6.25-rc8-mm1 panic in rpaphp_register_slot()

[Benjamin Herrenschmidt]

On Mon, 2008-04-21 at 22:05 -0600, Alex Chiang wrote:
> 
> Are you saying that it is not accurate to use this
> pci_bus->self->devfn to keep track of slots?

Well, if it's a PHB, there's no self.

> I suppose you could just pass in 0 as slot_nr/devfn. That is what
> my fixup patch did if it couldn't find a pci_bus->self. The
> result would be that for a given pci_bus, you would only see the
> first "slot" with this 0 slot_nr appear in sysfs, and it would
> have whatever name originally associated with your dn.

Yes but we can have a PHB with no self and suddenly the HV brings in
multiple devices behind it. Oh well, I need to dig more, if I manage to
get the bloody hotplug stuff working here at all..

In some case, we don't even have the PHB, so nothing will appear in
sysfs but that's probably mostly harmless. The main thing is that those
hotplug operations are never driven that way, they are driven by the
management console which talks to a daemon which talks to the HV etc...
and the kernel is the last one to know about hotplug :-)

> I think if I were to understand more about this issue, we could
> figure out a better solution...

Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/