Re: kgdb: fix optional arch functions and probe_kernel_*

[Ingo Molnar]

* Jason Wessel <jason.wessel@xxxxxxxxxxxxx> wrote:

> >> Still.  Do we need the set_fs() in there?  
> >> __copy_from_user_inatomic() is a "__" uaccess function and hence 
> >> shouldn't be running access_ok()?
> >
> > yeah, i guess that's true. Jason?
> 
> In so far as the testing showed, it worked ok on the X86 arch with and 
> without the set_fs(), but on ARM it is absolutely required.  This 
> means we have to decide to make arch specific or leave generic as it 
> stands right now.

yeah, i guess so - it's no big issue as this isnt performance critical 
in any way. Do you know which exact codepath/mechanism in ARM relies on 
the set_fs() being there?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/