Re: [PATCH 1/11] Add generic helpers for arch IPI function calls

From: Avi Kivity
Date: Tue Apr 22 2008 - 10:38:38 EST


Jens Axboe wrote:
Introducing this fallback will make any usage from irq disabled context
deadlock prone.

I rather like the current interface.

Hmm good point, I'll back that bit out again.

But then you need to fix all callers to handle errors.

Perhaps we need a new flag for failable async IPIs (or better, API). I'm pretty sure no one uses s_c_f_s() from irq disabled context on x86, since it will WARN_ON(irqs_disabled()).

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/