Re: [PATCH 01 of 12] Core of mmu notifiers

[Avi Kivity]

Andrea Arcangeli wrote:
> On Tue, Apr 22, 2008 at 04:56:10PM +0200, Eric Dumazet wrote:
>   
> > Andrea Arcangeli a écrit :
> >     
> > > +
> > > +static int mm_lock_cmp(const void *a, const void *b)
> > > +{
> > > +	cond_resched();
> > > +	if ((unsigned long)*(spinlock_t **)a <
> > > +	    (unsigned long)*(spinlock_t **)b)
> > > +		return -1;
> > > +	else if (a == b)
> > > +		return 0;
> > > +	else
> > > +		return 1;
> > > +}
> > > +
> > >       
> > This compare function looks unusual...
> > It should work, but sort() could be faster if the
> > if (a == b) test had a chance to be true eventually...
> >     
>
> Hmm, are you saying my mm_lock_cmp won't return 0 if a==b?
>
>   

You need to compare *a to *b (at least, that's what you're doing for the 
< case).

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/