Re: [Patch 6/6] Ptrace support for HARDWARE_WATCHPOINTS.

From: Daniel Jacobowitz
Date: Tue Apr 22 2008 - 12:55:06 EST


On Mon, Apr 21, 2008 at 05:40:11PM -0700, David Daney wrote:
> +struct mips32_watch_regs {
> + unsigned int num_valid;
> + unsigned int reg_mask;
> + unsigned int irw_mask;
> + unsigned long watchlo[8];
> + unsigned int watchhi[8];
> +};

Please do not use long in new ptrace interfaces. Use either
uint32_t or uint64_t as appropriate so that it doesn't depend
on how the kernel or debugger was built.

--
Daniel Jacobowitz
CodeSourcery
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/