Re: [PATCH] xfs: #define out unused parametersof?xfs_bmap_add_free and xfs_btree_read_bufl

[Adrian Bunk]

On Tue, Apr 22, 2008 at 07:50:54PM +0200, Denys Vlasenko wrote:
> On Tuesday 22 April 2008 19:26, Eric Sandeen wrote:
> > >> I want to eventually reach the state with no warnings
> > >> about unused parameters.
> > > 
> > > The standard kernel pattern in using empty static inline functions (that 
> > > allow type checking).
> > > 
> > > And I'm not sure whether the number of functions you'd have to change 
> > > for reaching your goal has four, five or six digits.
> > 
> > It would be a huge undertaking.
> > 
> > Just building xfs w/ the warning in place exposes tons of unused
> > parameter warnings from outside xfs as well.
> 
> Eh... I meant "no warnings about unused parameters" for fs/xfs/* only,
> not for the entire kernel. I filter out other warnings.
> 
> I want to do it not as an excercise in perfectionism,
> but as means of making sure we do not waste stack
> passing useless parameters, which is important for xfs.

That's not really maintainable, and the stack gains are too small for 
bringing us significantely nearer to a solution.

> vda

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/