Re: [PATCH] xfs: #define out unused parameters for seven functions in xfs_trans.h

[David Chinner]

On Tue, Apr 22, 2008 at 01:51:03PM +0200, Denys Vlasenko wrote:
> [ resend: now with patch attached! :) ]
> 
> Hi David,
> 
> Seven xfs_trans_XXX functions declared in xfs_trans.h
> are not using "tp" parameter in non-debug builds,
> but it still takes stack space since these functions
> are not static and gcc cannot optimize it out.

Same as my last comments - I don't think the savings are
worth the additional clutter it introduces.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/