Re: [PATCH 02 of 12] Fix ia64 compilation failure because ofcommon code include bug

From: Robin Holt
Date: Tue Apr 22 2008 - 19:08:37 EST


On Wed, Apr 23, 2008 at 12:43:52AM +0200, Andrea Arcangeli wrote:
> On Tue, Apr 22, 2008 at 01:22:55PM -0700, Christoph Lameter wrote:
> > Looks like this is not complete. There are numerous .h files missing which
> > means that various structs are undefined (fs.h and rmap.h are needed
> > f.e.) which leads to surprises when dereferencing fields of these struct.
> >
> > It seems that mm_types.h is expected to be included only in certain
> > contexts. Could you make sure to include all necessary .h files? Or add
> > some docs to clarify the situation here.
>
> Robin, what other changes did you need to compile? I only did that one
> because I didn't hear any more feedback from you after I sent that
> patch, so I assumed it was enough.

It was perfect. Nothing else was needed.

Thanks,
Robin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/