Re: [PATCH] linux/atm_tcp.h: cleanup for userspace

[David Miller]

From: Mike Frysinger <vapier@xxxxxxxxxx>
Date: Wed, 23 Apr 2008 23:03:51 -0400

> On Wednesday 23 April 2008, David Miller wrote:
> > From: Mike Frysinger <vapier@xxxxxxxxxx>
> > > The atm_tcp.h uses types from linux/atm.h, but does not include it.  It
> > > should also use the standard __u## types from linux/types.h rather than
> > > the uint##_t types since the former can be found with the kernel already.
> > >
> > > Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>
> >
> > I don't think this is a sufficient patch to solve these problems.
> 
> it is sufficient for atm_tcp.h only.  many of the network headers are broken 
> for userspace inclusion, so i've just been posting them one at a time as last 
> time i posted a large patch, no one picked it up.

But you're adding an include of another file that has the problem
you're supposedly fixing.

If using uintN_t types is the problem, you're adding a new one for
applications that include linux/atm_tcp.h, because now they'll
get linux/atm.h as a side effect which does it too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/