Re: kvm: how big is type?

[Avi Kivity]

Izik Eidus wrote:
> Avi Kivity wrote:
>   
> > Harvey Harrison wrote:
> >     
> > > arch/x86/kvm/x86.c:3484:25: warning: cast truncates bits from constant
> > > value (100 becomes 0)
> > > arch/x86/kvm/x86.c:3510:24: warning: cast truncates bits from constant
> > > value (100 becomes 0)
> > >
> > > The problem:
> > >         cseg_desc.type &= ~(1 << 8); //clear the B flag
> > >         nseg_desc.type |= (1 << 8);
> > >
> > > type is a 4-bit bitfield on x86....please look into this.
> > >
> > >   
> > >       
> > I think it ought to be (1 << 1), not (1 << 8), as it refers to the
> > "busy" bit of the task type.  Izik?
> >
> >
> >     
> From cf6e76c69a38a983df0c84a3dcc2336042eb3436 Mon Sep 17 00:00:00 2001
> From: Izik Eidus <izike@xxxxxxxxxxxx>
> Date: Mon, 28 Apr 2008 18:16:08 +0300
> Subject: [PATCH] KVM: x86: task switch: fix wrong bit setting for the busy flag.
>  the busy bit is in offset of 1 inside type and not in 8.
>   

Applied, thanks.


--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/