Re: [patch] input: JOYSTICK_XPAD build fix

[Ingo Molnar]

* Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:

> > which triggers with the following config:
> > 
> >  http://redhat.com/~mingo/misc/config-Wed_Apr_30_21_43_17_CEST_2008.bad
> > 
> > the reason is dependency on NEW_LEDS that was not spelled out in the 
> > Kconfig entry of JOYSTICK_XPAD.
> 
> Xpad can be compiled without LED support so this dependancy is 
> incorrect. JOYSTICK_XPAD_LEDS has proper dependancy on LEDS_CLASS, the 
> rest is Kconfig breakage.

no, you are wrong, read the current Kconfig rules again. If the user can 
create a .config that does not build, it is driver breakage. It always 
was, and has been in the past 15 years.

Kconfig might be extended to make dependencies easier to manage for 
developers but until that is implemented you have to craft your driver's 
dependencies with the current tools in a way that doesnt break the 
build.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/