Re: [PATCH 1/4] lib: add ascii hex helper functions

From: Andrew Morton
Date: Thu May 01 2008 - 17:15:30 EST


On Thu, 01 May 2008 13:51:07 -0700
Harvey Harrison <harvey.harrison@xxxxxxxxx> wrote:

> Everyone rolls their own version around the tree, centralize
> in lib/hexdump.c
>
> +extern const char hex_asc[];
> +const char hexasc[16] = "0123456789abcdef";

If I were a compiler I'd get upset about that.

Honest, 24 hours really doesn't matter here. Do it carefully, do
it right.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/