Re: [PATCH] add typecheck on irqsave and friends for correct flags

[Andrew Morton]

On Thu, 1 May 2008 19:51:18 -0400 (EDT)
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> There has been several areas in the kernel where an int has been used
> for flags in local_irq_save and friends instead of a long. This can
> cause some hard to debug problems on some architectures.
> 
> This patch adds a typecheck inside the irqsave and restore functions
> to flag these cases.

hm, not exactly a thing of beauty, but it could have been worse.


If we had implemeted these things properly, as

	unsigned long spin_lock_irqsave(spinlock_t *lock);

then we wouldn't be able to do this at all.

Oh well, thanks, I'll toss it in there.  Maybe this should go into
git-sched (aka git-omnibus)?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/