Re: [PATCH] kernel/time.c: Silence gcc warning 'integer constantto large for long type'

[H. Peter Anvin]

Linus Torvalds wrote:
> On Fri, 2 May 2008, H. Peter Anvin wrote:
> > kernel/time.c: In function msecs_to_jiffies:
> > kernel/time.c:479: warning: integer constant is too large for long type
>
> Shouldn't we fix the perl-script to mark the constants appropriately 
> typed? Ie add the proper "ul" or "ull" endings there as necessary?
>
> For example, I see
>
> 	#define MSEC_TO_HZ_ADJ64        0x18000000000000000
>
> in the auto-generated timeconst.h file, and the fact is, that's a really 
> really ugly constant. It simply doesn't even fit in a u64. Why do these 
> kinds of pointless and useless #define even get generated, when using them 
> would inevitably be a bug anyway?
>
> As to the ones that *do* fit in 64 bits, they should still haev the 
> correct "ul" and "ull" endings on 64- and 32-bit architectures 
> respectively. Yeah, hex constants are always unsigned and the compiler 
> will expand them to the right size, but the compiler is also rigth to warn 
> about it (and casting them shouldn't even change that fact, even if it 
> happens to do so with gcc).

That's more or less what my other patchset does.  It's a bit more 
complex (because it gets the suffixes via macros, to get the right 
suffixes), but most of it is pure cleanup of the way we handle integers 
in architecture includes:

git://git.kernel.org/pub/scm/linux/kernel/git/hpa/linux-2.6-inttypes.git

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/