Re: [PATCH 12/12] net: use the common ascii hex helpers

[Harvey Harrison]

On Fri, 2008-05-02 at 16:31 -0700, Andrew Morton wrote:
> On Fri, 02 May 2008 16:25:15 -0700 (PDT)
> David Miller <davem@xxxxxxxxxxxxx> wrote:
> 
> > From: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> > Date: Fri, 02 May 2008 12:01:56 -0700
> > 
> > > Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> > 
> > Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>
> > 
> > This has to go in via who ever adds the first patch
> > with the actual helpers, so I won't apply this one.
> 
> Yup.  After a bit of testing and tyre-kicking I'll probably slip
> lib-add-ascii-hex-helper-functions.patch into mainline so that we can
> trickle all the *-use-the-common-ascii-hex-helpers.patch patches out to the
> various maintainers.
> 

I suppose the hex_asc array and hex_to_int could also use
EXPORT_SYMBOL().

Also, As I've looked further around the tree, there seem to be a lot
of hex_to_int/long variants around the tree, so what I'm thinking is
the current hex_to_int becomes hex_to_u8 and I'll add a:

/**
 * hex_to_u32 - read a u32 from a char buffer
 * @buf: buffer to read ascii chars from
 * @val: where to put the u32
 *
 * Read hex-ascii chars into a u32.  Return the number of chars read.
 * A maximum of 8 chars will be read, if a char not in [a-f][A-F][0-9]
 * is encountered, the function returns.
 */
int hex_to_u32(const char *buf, u32 *val)

Similar to the above, but a max of 16 chars will be read.
int hex_to_u64(const char *buf, u64 *val)

If this api is better, I suppose:

int hex_to_u8 - max of two chars
int hex_to_u16 - max of 4
int hex_to_u32 - max of 8
int hex_to_u64 - max of 16

Could be added around a common function that takes the max length as
an additional arg.

Thoughts?

Harvey


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/