Re: [PATCH 12/12] net: use the common ascii hex helpers

[Harvey Harrison]

On Fri, 2008-05-02 at 17:08 -0700, Andrew Morton wrote:
> On Fri, 02 May 2008 16:52:43 -0700
> Harvey Harrison <harvey.harrison@xxxxxxxxx> wrote:
> 
> > On Fri, 2008-05-02 at 16:31 -0700, Andrew Morton wrote:
> > > On Fri, 02 May 2008 16:25:15 -0700 (PDT)
> > > David Miller <davem@xxxxxxxxxxxxx> wrote:
> > > 
> > > > From: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> > > > Date: Fri, 02 May 2008 12:01:56 -0700
> > > > 
> > > > > Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> > > > 
> > > > Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>
> > > > 
> > > > This has to go in via who ever adds the first patch
> > > > with the actual helpers, so I won't apply this one.
> > > 
> > > Yup.  After a bit of testing and tyre-kicking I'll probably slip
> > > lib-add-ascii-hex-helper-functions.patch into mainline so that we can
> > > trickle all the *-use-the-common-ascii-hex-helpers.patch patches out to the
> > > various maintainers.
> > > 
> > 
> > I suppose the hex_asc array and hex_to_int could also use
> > EXPORT_SYMBOL().
> 
> gack.  How could you do all those patches without discovering this?  Please
> go give your QA staff a wedgie.

allyesconfig :(

> > 
> 
> yes, hex_to_u8() is more specific and better defined than hex_to_int().
> 
> Although anally it should perhaps be two_digit_hex_to_ulong,
> four_digit_hex_to_ulong, etc.
> 
> ho hum, I'll drop them all.

My apologies, how about:

int hex_char_to_int(char ch)
int hex_char_to_int(char ch)
int hex_char_to_int(char ch)

EXPORT_SYMBOL(hex_dump_to_buffer);




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/