Re: x86 git acpi issue?
From: Hiroshi Shimamoto
Date: Fri May 02 2008 - 20:31:19 EST
H. Peter Anvin wrote:
> Hiroshi Shimamoto wrote:
>> Hi,
>>
>> commit: afcab879e4044f952b7a031d5fd504e0feb7df41
>> visws: build fix
>>
>> breaks something around acpi on 32bit.
>> In my test box scsi driver complains and the kernel doesn't boot.
>>
>> I'm not sure, but when moving the acpi.o before legacy.o, it works.
>> --- a/arch/x86/pci/Makefile_32
>> +++ b/arch/x86/pci/Makefile_32
>> @@ -6,11 +6,11 @@ obj-$(CONFIG_PCI_DIRECT) += direct.o
>> obj-$(CONFIG_PCI_OLPC) += olpc.o
>>
>> pci-y := fixup.o
>> +pci-$(CONFIG_ACPI) += acpi.o
>> pci-y += legacy.o irq.o
>>
>> pci-$(CONFIG_X86_VISWS) := visws.o fixup.o
>> pci-$(CONFIG_X86_NUMAQ) := numa.o irq.o
>> -pci-$(CONFIG_ACPI) += acpi.o
>> pci-$(CONFIG_NUMA) += mp_bus_to_node.o
>>
>> obj-y += $(pci-y) common.o early.o
>>
>> of cause this isn't correct patch, it's just a workaround for me.
>>
>
> The problem is that := should be += for the VISWS and NUMAQ lines.
> There is already a patch queued up to fix that.
>
OK, thanks.
Hiroshi Shimamoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/