Re: [patch 4/4] MIPS: ELF handling - use SELFMAG instead ofnumeric constant

From: Cyrill Gorcunov
Date: Sat May 03 2008 - 06:36:59 EST


[Cyrill Gorcunov - Sat, May 03, 2008 at 02:18:04PM +0400]
| Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
| ---
|
| Index: linux-2.6.git/arch/mips/kernel/vpe.c
| ===================================================================
| --- linux-2.6.git.orig/arch/mips/kernel/vpe.c 2008-04-15 23:01:26.000000000 +0400
| +++ linux-2.6.git/arch/mips/kernel/vpe.c 2008-05-02 21:40:57.000000000 +0400
| @@ -840,7 +840,7 @@ static int vpe_elfload(struct vpe * v)
|
| /* Sanity checks against insmoding binaries or wrong arch,
| weird elf version */
| - if (memcmp(hdr->e_ident, ELFMAG, 4) != 0
| + if (memcmp(hdr->e_ident, ELFMAG, SELFMAG) != 0
| || (hdr->e_type != ET_REL && hdr->e_type != ET_EXEC)
| || !elf_check_arch(hdr)
| || hdr->e_shentsize != sizeof(*sechdrs)) {
|
| --
|
oops, MIPS was not refreshed by whole. This is a fix.
---

From: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
Subject: MIPS: ELF handling - use SELFMAG instead of numeric constant

Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
---

Index: linux-2.6.git/arch/mips/kernel/vpe.c
===================================================================
--- linux-2.6.git.orig/arch/mips/kernel/vpe.c 2008-04-15 23:01:26.000000000 +0400
+++ linux-2.6.git/arch/mips/kernel/vpe.c 2008-05-03 14:28:47.000000000 +0400
@@ -840,7 +840,7 @@ static int vpe_elfload(struct vpe * v)

/* Sanity checks against insmoding binaries or wrong arch,
weird elf version */
- if (memcmp(hdr->e_ident, ELFMAG, 4) != 0
+ if (memcmp(hdr->e_ident, ELFMAG, SELFMAG) != 0
|| (hdr->e_type != ET_REL && hdr->e_type != ET_EXEC)
|| !elf_check_arch(hdr)
|| hdr->e_shentsize != sizeof(*sechdrs)) {
@@ -1107,7 +1107,7 @@ static int vpe_release(struct inode *ino
return -ENODEV;

hdr = (Elf_Ehdr *) v->pbuffer;
- if (memcmp(hdr->e_ident, ELFMAG, 4) == 0) {
+ if (memcmp(hdr->e_ident, ELFMAG, SELFMAG) == 0) {
if (vpe_elfload(v) >= 0) {
vpe_run(v);
} else {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/