Re: i387/FPU init issues...

[Ingo Molnar]

* jamal <hadi@xxxxxxxxxx> wrote:

> > we have:
> > #define P6_NOP3 ".byte 0x0f,0x1f,0x00\n"
> 
> Dang - I feel i should have saved myself all that git bisecting
> and just posted the oops ;->

your bisection was still very useful - it pinpointed the NOPs - the 
assembly code around the NOP changed so a different length NOP was 
patched in => which did not work on your CPU. So thanks for that! The 
fix is already in x86.git (we'll update the commit log).

> > So the alternatives code applies the wrong nop padding for your CPU. 
> > This was probably introduced with commit 
> > 32c464f5d9701db45bc1673288594e664065388e.
> > 
> > Jan, are you sure that P3 knows the P6 NOPs ? AFAICT its P4, but I 
> > have to dig up the manuals.
> > 
> > Jamal, does the following patch solve your problem ?
> 
> Indeed it does - thanks.

great. So this NOP is indeed not generally known to all "P6 and later" 
CPUs. (the PII)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/