Re: Remove Asus EEE UDMA/33 limitation.

From: Robert Hancock
Date: Sat May 03 2008 - 15:34:27 EST


Alan Cox wrote:
On Sat, 3 May 2008 10:58:17 +0100
Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote:

On Fri, May 02, 2008 at 11:44:58AM -0400, Dave Jones wrote:

static const struct ich_laptop ich_laptop[] = {
/* devid, subvendor, subdev */
+ { 0x2653, 0x1043, 0x82d8 }, /* ICH6M on Asus Eee PC */
{ 0x27DF, 0x0005, 0x0280 }, /* ICH7 on Acer 5602WLMi */
{ 0x27DF, 0x1025, 0x0102 }, /* ICH7 on Acer 5602aWLMi */
{ 0x27DF, 0x1025, 0x0110 }, /* ICH7 on Acer 3682WLMi */
Don't the ACPI timing methods let us work this out without requiring machine specific knowledge?

We don't currently sniff the ACPI timing data on Intel boxes - we can do
so and there is a library routine but I'd be worried about the usual
standard of BIOS code. Right now we only do it for chipsets which are so
braindamaged we have no other choice or where the vendor specifically
implemented and intended the ACPI data to be used for this (eg Nvidia)

Given that the bootup ACPI _GTM results will be used by Windows to determine the DMA mode setting with the standard Microsoft atapi.sys driver which PATA controllers would typically use, and Windows is what the majority of this hardware was designed to run, I think it should be quite trustworthy..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/