Re: [PATCH 17/56] microblaze_v2: checksum support

[Arnd Bergmann]

On Sunday 04 May 2008, monstr@xxxxxxxxx wrote:
> + *
> + * INET                An implementation of the TCP/IP protocol suite for the LINUX
> + *             operating system.  INET is implemented using the  BSD Socket
> + *             interface as the means of communication with the user level.
> + *
> + *             IP/TCP/UDP checksumming routines
> + *
> + * Authors:    Jorge Cwik, <jorge@xxxxxxxxxxxxxxxxx>
> + *             Arnt Gulbrandsen, <agulbra@xxxxxxxxxxx>
> + *             Tom May, <ftom@xxxxxxxxxx>
> + *             Andreas Schwab, <schwab@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> + *             Lots of code moved from tcp.c and ip.c; see those files
> + *             for more names.

This is a pretty generic implementation, and you copied it from another
architecture. How about moving it from arch/microblaze/lib/ to lib/?
I'd suggest building it conditionally under CONFIG_GENERIC_CSUM,
which you def_bool in your architecture Kconfig.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/