Re: [PATCH] modpost: i2c aliases need no trailing wildcard

From: Rusty Russell
Date: Sun May 04 2008 - 20:09:23 EST


On Saturday 03 May 2008 04:37:21 Jean Delvare wrote:
> Hi all,
>
> [Once more with Sam's address fixed, sorry for the noise.]
>
> Not all device types need a wildcard at the end of their module
> aliases. In particular, for i2c module aliases, the trailing wildcard
> is not only unneeded, it could also cause the wrong driver to be
> loaded.

Hi Jean,

i2c would have been better using a terminator char after the device name.
The wildcard would then allow future extensions without having the current
potential confusion.

Still, there's nothing wrong with this patch, happy for you to send it.

Acked-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/