Re: [patch] irda: fix !PNP support in drivers/net/irda/nsc-ircc.c

[David Miller]

From: Ingo Molnar <mingo@xxxxxxx>
Date: Sat, 3 May 2008 21:32:23 +0200

> 
> x86.git testing found the following build failure in latest -git:
> 
>  drivers/built-in.o: In function `nsc_ircc_pnp_probe':
>  nsc-ircc.c:(.text+0xdf1b6): undefined reference to `pnp_get_resource'
>  nsc-ircc.c:(.text+0xdf1d4): undefined reference to `pnp_get_resource'
>  nsc-ircc.c:(.text+0xdf1ee): undefined reference to `pnp_get_resource'
>  nsc-ircc.c:(.text+0xdf237): undefined reference to `pnp_get_resource'
>  nsc-ircc.c:(.text+0xdf24c): undefined reference to `pnp_get_resource'
>  drivers/built-in.o:nsc-ircc.c:(.text+0xdf266): more undefined references to `pnp_get_resource' follow
>  make: *** [.tmp_vmlinux1] Error 1

I feel there is a better way to fix this and the other IRDA
pnp build failure.

linux/pnp.h provides erroring inlines when PNP is disabled, but it
does not provide a full set.  In order to be fully consistent it
should provide similar stub implementations for things like
pnp_get_flags() (which is what triggers the reference to
pnp_get_resource here), for example.

Either the whole API is provided with stubs when PNP is disabled, or
none should be.  If only some interfaces get the treatment, we get
messy ifdefs such as those seen in these patches we are discussing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/