Re: [PATCH 2/3] ide: set REQ_NOMERGE request flag in ide_do_drive_cmd()

From: Bartlomiej Zolnierkiewicz
Date: Mon May 05 2008 - 12:33:20 EST


On Monday 05 May 2008, FUJITA Tomonori wrote:
> On Sat, 3 May 2008 15:14:24 +0200
> Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> wrote:
>
> > This is a preparation for converting IDE to use blk_execute_rq().
> >
> > There should be no functional changes caused by this patch.
> >
> > Cc: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
> > Cc: Borislav Petkov <petkovbb@xxxxxxxxx>
> > Cc: Jens Axboe <jens.axboe@xxxxxxxxxx>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
> > ---
> > drivers/ide/ide-io.c | 2 ++
> > 1 file changed, 2 insertions(+)
>
> I think that you can drop this since the block layer doesn't check
> REQ_NOMERGE with the way ide_do_drive_cmd queues requests.

Yeah, I see now that REQ_NOMERGE only matters for fs requests.

Dropped.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/