Re: [2.6 patch] mm/page_alloc.c: cleanups

[KOSAKI Motohiro]

>  > >  that's a bug, surely?  I bet there are plenty of places which should be
>  > >  using this hint.
>  >
>  > Hm, as far as I investigate
>  >
>  > 1. nobody used free_cold_page() in kernel code tree.
>  > 2. free_cold_page() doesn't exported.
>  >
>  > I investigated to 2.6.25-mm1.
>  > I don't understand yet why you think plenty....
>
>  Any place in the kernel which frees a page which is probably cache-cold
>  should be using this function.  (Including any place which caused the page
>  to be evicted from CPU cache by placing it under DMA).

Ah, Agreed.

Adrian, Can you remove free_cold_page() change in your patch?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/