Re: [PATCH 2/2] kconfig: make oldconfig less chatty and clean upconf.c

[Roman Zippel]

Hi,

On Sun, 4 May 2008, Sam Ravnborg wrote:

> We now check for valid stadin in both cases and this
> may break a script here and there.

I strongly disagree with this, please preserve the old behaviour. It took 
a while to work out the current behaviour.
Only silentoldconfig checks for stdin because it's used as hook during 
kbuild to verify the config. For all other interactive targets the user 
has to know what he's doing, e.g. it's valid to do "yes '' | make 
oldconfig".

> -		switch (input_mode) {
> -		case set_no:	 name = "allno.config"; break;
> -		case set_mod:	 name = "allmod.config"; break;
> -		case set_yes:	 name = "allyes.config"; break;
> -		case set_random: name = "allrandom.config"; break;
> -		default: break;
> -		}
> -		if (!stat(name, &tmpstat))
> -			conf_read_simple(name, S_DEF_USER);
> -		else if (!stat("all.config", &tmpstat))
> -			conf_read_simple("all.config", S_DEF_USER);
> -		break;
> -	default:
> -		break;
>  	}

This isn't yet in aconf.c.

bye, Roman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/