Re: [PATCH] sched: fix SCHED_OTHER balance iterator to include alltasks

[Ingo Molnar]

* Gregory Haskins <ghaskins@xxxxxxxxxx> wrote:

> Hi Ingo,
>  The follow patch applies to sched-devel.  I know the original 
>  function was somehow trying to protect against dequeueing by 
>  pre-iterating.  I am not sure if I captured the intent properly in 
>  that regard.  What I can say is that the old algorithm would miss 
>  tasks, and that is now fixed.  It may need further adjustment if I 
>  missed the pre-iterating operation.
> 
> Hi Peter,
>  I was wrong earlier when I mentioned there might be a problem with 
>  entity_is_task().  I think this was the root cause of what I was 
>  seeing. Sorry for the red-herring.

applied Gregory, thanks. Nice fix! Peter, do you concur with Gregory's 
analysis?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/