Re: [RFC PATCH 2/6] kbuild: let addtree result in absolute pathsonly

[Peter Oberparleiter]

Sam Ravnborg wrote:
> On Mon, May 05, 2008 at 05:24:16PM +0200, Peter Oberparleiter wrote:
>> From: Peter Oberparleiter <peter.oberparleiter@xxxxxxxxxx>
>> Signed-off-by: Peter Oberparleiter <peter.oberparleiter@xxxxxxxxxx>
>> ===================================================================
>> --- linux-2.6.26-rc1.orig/scripts/Kbuild.include
>> +++ linux-2.6.26-rc1/scripts/Kbuild.include
>> @@ -144,7 +144,7 @@ ld-option = $(call try-run,\
>>  build := -f $(if $(KBUILD_SRC),$(srctree)/)scripts/Makefile.build obj
>>  
>>  # Prefix -I with $(srctree) if it is not an absolute path.
>> -addtree = $(if $(filter-out -I/%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1))) $(1)
>> +addtree = $(if $(filter-out -I/%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1)),$(1))
>>  
>>  # Find all -I options and call addtree
>>  flags = $(foreach o,$($(1)),$(if $(filter -I%,$(o)),$(call addtree,$(o)),$(o)))
> 
> We try to make all paths relative so less files get rebuild if you access the
> same source from two different paths (think nfs mounted src etc).
> So you really need to justify this change.

I understand your point about keeping as many paths as possible relative
and would like to discuss that in the reply to patch 3, where most
changes towards absolute paths are done.

As for this patch: on second thought I think this change makes no sense
without the next patch - I'll have to redo them both.


Regards,
  Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/