Re: [PATCH] mm/cgroup.c add error check

[Andi Kleen]

KOSAKI Motohiro wrote:
>>  > on heavy workload, call_usermodehelper() may failure
>>  > because it use kzmalloc(GFP_ATOMIC).
>>
>>  Better just fix it to not use GFP_ATOMIC in the first place.
> 
> Ah, makes sense.
> I'll try toi create that patch.

Thanks.

> 
> but if GFP_KERNEL is used, We still need error check, IMHO.

Yes, but no retry (or if you're sure you cannot fail use __GFP_NOFAIL
too, but that is nasty because it has some risk of deadlock under severe
oom conditions)

-Andi


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/