Re: [PATCH] Silence 'ignoring return value' warnings indrivers/video/aty/radeon_base.c

[Benjamin Herrenschmidt]

On Tue, 2008-05-06 at 14:43 -0700, David Miller wrote:
> > So I rewrote the title to "drivers/video/aty/radeon_base.c: notify
> user if
> > sysfs_create_bin_file() failed".
> > 
> > And your fix looks appropriate - if sysfs_create_bin_file() fails we
> will now get
> > reports of this and we can find out what kernel bug caused this to
> happen.
> 
> The last time someone "fixed" this warning in the radeon driver,
> people lost their consoles.
> 
> Just giving a heads up...

I asked Tony to only warn. I still don't like it tho. As I (and paulus)
have explained several times in the past, but I'm not going to veto the
patch because I'm tired of that argument.
 
We have something like 99% of users of sysfs_create_file not supposed to
fail right ?

So what we are effectively doing is adding -hundreds- of printk's all
over the place (bloat bloat bloat) while instead we could have warned
inside sysfs_create_file itself, and provided a __sysfs_create_file or
sysfs_create_file_nowarn, or whatever you want to call it for the
handful of users that actually want to explicitely deal with failures.

And it's the same for a whole bunch of those must check things. We are
just adding bloat often for nothing useful. In some case, even harmful
as we prevent entire modules from initializing due to what is often just
a minor failure.

Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/