Re: [PATCH] Silence 'ignoring return value' warnings indrivers/video/aty/radeon_base.c

[Andrew Morton]

On Tue, 6 May 2008 21:00:55 -0700 Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:

> ...
>
> > +	if (err)
> > +		pr_warning("%s() Creating sysfs files failed,
> > continuing\n",
> > +		           __func__);
> >  
> >  	/* save current mode regs before we switch into the new one
> >  	 * so we can restore this upon __exit
> > _
> > 
> > 
> > So from what you say, it sounds like we will be seeing that warning.
> > I wonder why.
> 
> can we make it a WARN_ON() as well? that way we'll see it in various
> kerneloops.org stats etc etc.. and we also get a nice backtrace for
> free to go with it....
> 
> (rationale: users tend to not read their dmesg much, but WARN_ON()'s do
> get noticed)

OK by me, although if we're going to do much more of this it might be time
to add a WARN_ON which takes (fmt, args...).

Which should be called WARN, but of course 12,000,000 drivers have gone and
screwed that up with indiscriminate namespace poaching.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/