Re: [PATCH] Silence 'ignoring return value' warnings indrivers/video/aty/radeon_base.c

From: Arjan van de Ven
Date: Wed May 07 2008 - 00:42:38 EST


On Tue, 6 May 2008 21:26:43 -0700
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Tue, 6 May 2008 21:23:14 -0700 Andrew Morton
> <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> > otcompletelyoh, perhaps we could generate a backtrace from within
> > printk() itself for when it sees messages which have KERN_ERR or
> > some other suitably-chosen (and probably configurable) facility
> > level.
>
> and if that is impractical, perhaps create a new printk facility
> (KERN_TRACE?) which gets rewritten to KERN_ERR, but tells printk()
> to generate a trace.
>
> Do we really need the file-n-line info?

for me, it really does help to have that; it saves me and others time
to grep where exactly it happens. it also allows me to tie things to
gitweb automatically
(see http://www.kerneloops.org/search.php?search=write_msg for an
example of how this works; this feature is very appreciated by several
developers and was done on their request)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/