Re: It's time to hack on dentry_stat?

[rae l]

On Thu, May 8, 2008 at 12:10 AM, Ray Lee <ray-lk@xxxxxxxxxxxxx> wrote:
>  <shrug> Well, if there's one, then obviously there isn't. I'd assumed
>  it was a per-dentry overhead.

Good. If the binary application interface must be kept,
>  $ cat /proc/sys/fs/dentry-state
>  122104  115846  45      0       0       0
and to shrink dentry_stat can only save 16 bytes, there's no need to do this,

but the Documentation/ as this should be fixed?

Documentation/filesystems/proc.txt:

dentry-state
------------

Status of  the  directory  cache.  Since  directory  entries  are  dynamically
allocated and  deallocated,  this  file indicates the current status. It holds
six values, in which the last two are not used and are always zero. The others
are listed in table 2-1.

Table 2-1: Status files of the directory cache
..............................................................................
 File       Content
 nr_dentry  Almost always zero
 nr_unused  Number of unused cache entries
 age_limit
            in seconds after the entry may be reclaimed, when memory is short
 want_pages internally
..............................................................................

the age_limit and want_pages should be marked outdated and not used anymore,

But there's still one question:
1. Is age_limit always 45? Or the binary application interface would
expect it always 45?
   Can we change dentry_stat with 6 int values all initialized with
zero? Then the docs can be
   fixed with last four values not used and are always zero.

--
Cheng
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/